> On July 18, 2020, 1:10 a.m., Andrei Sekretenko wrote: > > Thanks! Now this patch addresses the main issue.
I updated the patch, this time I do not handle `approvers->approved<VIEW_ROLE>(resource)` in `void Master::Subscribers::Subscriber::send()` specifically since I do not find any `Error()` return from https://github.com/apache/mesos/blob/master/src/authorizer/local/authorizer.cpp#L601-L797 Could you please help reviewing it again ? - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72448/#review221252 ----------------------------------------------------------- On July 23, 2020, 5:03 p.m., Dong Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72448/ > ----------------------------------------------------------- > > (Updated July 23, 2020, 5:03 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This patch intends to fix issue MESOS-10085. > > When the authorization failed happens master return nothing to the > subscriber, subscriber isn't aware of what is happening, this issue > can lead to inconsistencies in Event stream. > > > Diffs > ----- > > include/mesos/master/master.proto 021dadcea026da41347b3aaee5ddd12f4f14fa29 > include/mesos/v1/master/master.proto > 488fe294e8bfe8e0c6fc23c88f06c0d41169b96d > src/common/http.hpp 02633e175c0848ee622cb5108a2e18db5e030641 > src/master/master.cpp a8cca622ff0bd172300b9a2717b4860ed06b620c > src/tests/master/mock_master_api_subscriber.cpp > 893d3e366164ccebd2847ed4c2874ab00e0e5b7b > > > Diff: https://reviews.apache.org/r/72448/diff/3/ > > > Testing > ------- > > - Manually tested > - make check > > > Thanks, > > Dong Zhu > >
