----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/#review221603 -----------------------------------------------------------
src/master/allocator/mesos/offer_constraints_filter.cpp Lines 117 (patched) <https://reviews.apache.org/r/72786/#comment310665> Published the PR and right after that realized that `RE2`s in the error state contain some kind of an error string. I should use that here. - Andrei Sekretenko On Aug. 17, 2020, 8:23 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72786/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2020, 8:23 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10173 > https://issues.apache.org/jira/browse/MESOS-10173 > > > Repository: mesos > > > Description > ------- > > Implemented regex-based offer constraints. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 > src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION > src/master/master.hpp 214307fcae47905672260758a1b96a034ed80257 > src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb > src/tests/master/offer_constraints_filter_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72786/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
