----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221611 -----------------------------------------------------------
src/slave/main.cpp Lines 583 (patched) <https://reviews.apache.org/r/72761/#comment310681> I think it should be `--ip_discovery_command` or `--ip` flag, right? https://github.com/apache/mesos/blob/1.10.0/src/slave/main.cpp#L328:L338 Ditto for the code in `src/tests/cluster.cpp`. src/slave/slave.cpp Lines 1746-1749 (patched) <https://reviews.apache.org/r/72761/#comment310682> We need to do this in `Slave::reregistered()` as well, because when agent is restarted, it will reregister rather than register with master in which case we want to call `CSIServer::start()` too. And if we decide to implement `CSIServer::start()` in the way that I mentioned in this comment (https://reviews.apache.org/r/72779/#comment310664), then I think `CSIServer::start()` do not need to return anything (just a void method), and here we do not need to handle its result. - Qian Zhang On Aug. 18, 2020, 9:25 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72761/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2020, 9:25 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > This patch adds a CSI server to the Mesos agent in both > the agent binary and in tests. > > > Diffs > ----- > > src/local/local.cpp 895057027165609c792089cd336988b65a3b305d > src/slave/main.cpp 0aa2cc9d254d0b74485a0584b9f55c2266f29367 > src/slave/slave.hpp 2cf45c616d5c50508bc5cd77096b0fef86542b1d > src/slave/slave.cpp c828d99ca9909b904767cc9ea5671b462714f547 > src/tests/cluster.hpp 415a60f5fd4881bca329ffd718f58d676653a17d > src/tests/cluster.cpp ab4cea49eb3e8cf18d320fbb30beaa3c454a08b0 > src/tests/mesos.hpp 0ad0999fba185539c90b053bda43be001da26253 > src/tests/mesos.cpp d6933a60c55802e6f9e89242608fbfad7631faed > src/tests/mock_slave.hpp 58daefa4459eaf15c2394f14db9f94527984b2b8 > src/tests/mock_slave.cpp fa2a0f5c8dadeb8aea87815741bc4fe071d5fbe0 > > > Diff: https://reviews.apache.org/r/72761/diff/2/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
