----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72743/#review221629 -----------------------------------------------------------
Ship it! src/master/master.cpp Lines 2671 (patched) <https://reviews.apache.org/r/72743/#comment310698> I see there's a ticket in the epic for this, nice :) src/master/master.cpp Lines 3260 (patched) <https://reviews.apache.org/r/72743/#comment310700> Hm.. consider using a field path? 'UpdateFramework.offer_constraints' are not valid: - Benjamin Mahler On Aug. 14, 2020, 4:57 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72743/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:57 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch makes SUBSCRIBE/UPDATE_FRAMEWORK calls actually construct > the offer constraints filter from the `offer_constraints` field and > pass it into the allocator. > > > Diffs > ----- > > src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb > > > Diff: https://reviews.apache.org/r/72743/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
