> On Aug. 24, 2020, 9:14 p.m., Benjamin Mahler wrote: > > Do we also want to be checking pseudoattributes? (Different enums and > > handling optionality (e.g. domain)).
We surely need. Added https://issues.apache.org/jira/browse/MESOS-10180 to the epic for this (and for other poorly covered functionality). - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72776/#review221695 ----------------------------------------------------------- On Aug. 24, 2020, 7:35 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72776/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2020, 7:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10172 > https://issues.apache.org/jira/browse/MESOS-10172 > > > Repository: mesos > > > Description > ------- > > Added basic tests for offer constraints on a string attribute equality. > > > Diffs > ----- > > src/tests/master/offer_constraints_filter_tests.cpp > f88e2011bc510323344ffe58fd550b7683242950 > > > Diff: https://reviews.apache.org/r/72776/diff/4/ > > > Testing > ------- > > `support/mesos-gtest-runner.py src/mesos-tests` > > > Thanks, > > Andrei Sekretenko > >
