> On Aug. 25, 2020, 10:41 p.m., Qian Zhang wrote: > > src/tests/csi_server_tests.cpp > > Lines 457 (patched) > > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457> > > > > It seems we only want to verify the behavior of CSI server but not > > launch a task from end to end, maybe we do not need to start master and > > agent just like what we do in `ROOT_InvalidPluginConfig`? > > Greg Mann wrote: > In this case, we still need the agent so that the CSI plugin can actually > be initialized successfully. > > Another option for this test would be to use a task launch to test this > same thing from end-to-end. I left it as-is because the task launching > boilerplate makes the test much larger, so this version is more concise. WDYT? > > Qian Zhang wrote: > > In this case, we still need the agent so that the CSI plugin can > actually be initialized successfully. > > Could you please elaborate a bit on this? Why do we need agent to make > sure the CSI plugin can actually be initialized? It seems we only need agent > ID when calling `csiServer.get()->start()`, but I think we can pass it a mock > agent ID like what `ROOT_InvalidPluginConfig` does, right? > > Greg Mann wrote: > Plugin initialization makes calls against the agent API in order to > launch the plugin. Without doing that, publish/unpublish calls cannot succeed.
I see, thanks! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221703 ----------------------------------------------------------- On Aug. 27, 2020, 2:12 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72728/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2020, 2:12 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > Added tests for the 'volume/csi' isolator. > > > Diffs > ----- > > src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b > src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 > src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72728/diff/11/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Greg Mann > >
