----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72826/#review221761 -----------------------------------------------------------
Ship it! src/tests/api_tests.cpp Lines 3411 (patched) <https://reviews.apache.org/r/72826/#comment310818> This NE check is redundant? - Benjamin Mahler On Aug. 31, 2020, 6:54 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72826/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2020, 6:54 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10166 > https://issues.apache.org/jira/browse/MESOS-10166 > > > Repository: mesos > > > Description > ------- > > This patch makes the test additionally check that the FRAMEWORK_UPDATED > event reports a reregistration time larger than the registration time. > > > Diffs > ----- > > src/tests/api_tests.cpp f222b43d1077d060c96daa81eb3b48b5bb76a05d > > > Diff: https://reviews.apache.org/r/72826/diff/1/ > > > Testing > ------- > > `src/mesos-tests --gtest_filter='*MasterAPITest.FrameworksEvent*' > --gtest_repeat=300` > > > Thanks, > > Andrei Sekretenko > >
