----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72945/#review222030 -----------------------------------------------------------
Ship it! The part that's not clear is why we can safely ignore it. If we don't have a solid answer, perhaps just add a TODO to figure out what we should do with it? - Benjamin Mahler On Oct. 13, 2020, 1:39 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72945/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2020, 1:39 a.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Bugs: MESOS-10192 > https://issues.apache.org/jira/browse/MESOS-10192 > > > Repository: mesos > > > Description > ------- > > The directory `/dev/nvidia-caps` was introduced in CUDA 11.0, just > ignore it since we only care about the Nvidia GPU device files. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > a0be1026bdaf7d4bb33f41e4c7d45666bd61f005 > > > Diff: https://reviews.apache.org/r/72945/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
