andreaspeters commented on a change in pull request #383:
URL: https://github.com/apache/mesos/pull/383#discussion_r624718800
##########
File path: src/python/cli_new/lib/cli/mesos.py
##########
@@ -504,13 +508,23 @@ def _attach_container_output(self):
client from the agent.
"""
+ # Set authentication header
+ auth = None
+ # pylint: disable=line-too-long
+ if self.config.agent_principal() is not None and
self.config.agent_secret() is not None:
+ auth = requests.auth.HTTPBasicAuth(
+ self.config.agent_principal(),
+ self.config.agent_secret()
+ )
+
Review comment:
U are right. I also moved it into the config.py. but I'm unsteady, maybe
it makes more sense in http.py. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
