----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74873/#review226224 -----------------------------------------------------------
src/linux/cgroups2.hpp Lines 27-41 (patched) <https://reviews.apache.org/r/74873/#comment314470> hm.. it doesn't seem like the caller needs to know about these, can you put them in the .cpp file? - Benjamin Mahler On Feb. 12, 2024, 5:04 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74873/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2024, 5:04 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Make all cgroup2 controls names constants that are available from: > ``` > cgroups2::control::<control> > ``` > > > Diffs > ----- > > src/linux/cgroups2.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/74873/diff/1/ > > > Testing > ------- > > > Thanks, > > Devin Leamy > >