bmahler commented on code in PR #497:
URL: https://github.com/apache/mesos/pull/497#discussion_r1498287970
##########
configure.ac:
##########
@@ -2502,14 +2502,14 @@ if test "x$enable_python" = "xyes" || \
AC_MSG_ERROR([only specify one of PYTHON or PYTHON_VERSION])
fi
- if test -n "$PYTHON"; then
- PYTHON_VERSION=`$PYTHON -c "import sys;
sys.stdout.write(sys.version[[:3]])"`
- fi
-
if test -n "$PYTHON_VERSION"; then
AC_SUBST([PYTHON], [python$PYTHON_VERSION])
fi
+ if test -n "$PYTHON"; then
+ PYTHON_VERSION=`$PYTHON -c "import sys;
sys.stdout.write(sys.version[[:3]])"`
+ fi
+
Review Comment:
now we're overriding PYTHON_VERSION if it's already set? (since now we're
setting PYTHON above when PYTHON_VERSION is set?)
##########
configure.ac:
##########
@@ -2502,14 +2502,14 @@ if test "x$enable_python" = "xyes" || \
AC_MSG_ERROR([only specify one of PYTHON or PYTHON_VERSION])
fi
- if test -n "$PYTHON"; then
- PYTHON_VERSION=`$PYTHON -c "import sys;
sys.stdout.write(sys.version[[:3]])"`
- fi
-
if test -n "$PYTHON_VERSION"; then
AC_SUBST([PYTHON], [python$PYTHON_VERSION])
fi
+ if test -n "$PYTHON"; then
+ PYTHON_VERSION=`$PYTHON -c "import sys;
sys.stdout.write(sys.version[[:3]])"`
+ fi
+
if test -z "$PYTHON" && test -z "$PYTHON_VERSION"; then
AM_PATH_PYTHON()
fi
Review Comment:
What does this do? Shouldn't this come before we start setting
PYTHON/PYTHON_VERSION in order to populate them when the user didn't provide
either?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
