----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74871/#review226247 -----------------------------------------------------------
s/suit/suite in the commit title, could shorten it to: `[cgroups2] Add cgroups2_tests.cpp.` (It's clear that it's adding a test to the suite). src/tests/containerizer/cgroups2_tests.cpp Lines 25-30 (patched) <https://reviews.apache.org/r/74871/#comment314485> We only want to execute cgroups v2 tests on hosts that have cgroups v2 enabled right and v1 tests only on hosts that have v1 enabled? It seems like this test needs a corresponding update to CgroupsFilter (e.g. "Cgroups" matches "Cgroups2", whoops!) and/or we add a Cgroups2Filter (might be cleaner to just have a single croups related filter though). https://github.com/apache/mesos/blob/1.11.0/src/tests/environment.cpp#L162-L219 - Benjamin Mahler On Feb. 26, 2024, 10:12 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74871/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2024, 10:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces cgroups2_tests.cpp which will hold the cgroups2 tests. > Adds a test that checks that cgroups2 is enabled on the testing host. > > > Diffs > ----- > > src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a > src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a > src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/74871/diff/4/ > > > Testing > ------- > > make -j128 check > > > Thanks, > > Devin Leamy > >
