bbannier commented on code in PR #516: URL: https://github.com/apache/mesos/pull/516#discussion_r1524323208
########## support/mesos-tidy/Dockerfile: ########## @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM ubuntu:xenial +FROM --platform=linux/amd64 ubuntu:xenial Review Comment: Hardcoding the platform is inconsistent with how you now document `docker run`; consistent would be to drop the modification here and instead document in the readme `docker build --platform=linux/amd64 ...`. That said, such a setup would still only work if the host is actually `amd64` (and e.g., fail on arm setups like newer macs unless the Docker VM emulates `amd64` and does not use the default `arm64` architecture). I wonder whether we shouldn't just get rid of all the hardcoded and documented platform code here completely; the `ubuntu:xenial` image we use is already multi-platform. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@mesos.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
