DevinLeamy commented on code in PR #539:
URL: https://github.com/apache/mesos/pull/539#discussion_r1543244829
##########
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp:
##########
@@ -30,6 +32,31 @@ namespace mesos {
namespace internal {
namespace slave {
+namespace cgroups2_isolator {
+
+Try<bool> supported()
Review Comment:
Could modify this to either:
1. Return `bool` and convert all `return Error`s into `return false`. Or,
2. Return `Try<Nothing>` and treat `Error()` as `false` and `Nothing()` as
true.
This would make it easier for the caller, as they don't have to check two
things (success and value). What's your take? @bmahler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
