----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74992/#review226454 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On May 15, 2024, 9:19 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74992/ > ----------------------------------------------------------- > > (Updated May 15, 2024, 9:19 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Modifies the cgroups CPU weights to reflect change > from cpu.shares to cpu.weight. > > In v1, cgroups used cpu.shares which has a default of 1024. > In v2, cgroups use cpu.weight which has a default of 100 > > The range for the cpu.weight is [1,10000], the minimum > weight has been updated to reflect this. > > The revocable CPU weight has been scaled down from 10 to 1 > to reflect a similar scale to the default. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/constants.hpp > 9498a4779fda90463c912fe3d478019caeca0b04 > src/slave/containerizer/mesos/isolators/cgroups2/controllers/cpu.cpp > 85fe063a734bafcac6dbf6992ecb8ed2492e3242 > > > Diff: https://reviews.apache.org/r/74992/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >