----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74998/ -----------------------------------------------------------
(Updated May 17, 2024, 10:01 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Fix if condition such that we only skip the enable call for the perf_event controller, also fixed ROOT_CGROUPS_PERF_Sample isolator test Repository: mesos Description ------- In Cgroups2IsolatorProcess::prepare, it may manually enable controller by writing to the cgroup.subtree_control process. For perf_event, since is is automatically turned on, it does not appear inside the cgroup.controllers file and hence cannot be written to the cgroup.subtree_control file. For this reason, we skip the enable call for the perf_event controller. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 76c8df9b10ff8142c89a812f24acb8c6accc0ae5 Diff: https://reviews.apache.org/r/74998/diff/2/ Changes: https://reviews.apache.org/r/74998/diff/1-2/ Testing ------- Thanks, Jason Zhou
