-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75046/#review226536
-----------------------------------------------------------




src/linux/routing/route.cpp
Line 99 (original), 99 (patched)
<https://reviews.apache.org/r/75046/#comment314778>

    what about this one and the one in diagnosis.cpp?


- Benjamin Mahler


On June 11, 2024, 10:59 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75046/
> -----------------------------------------------------------
> 
> (Updated June 11, 2024, 10:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when grabbing the destination, we would filter out the default 
> address at 0.0.0.0/0 by checking that the dst pointer is pointing at an empty 
> struct.
> With newer operating systems, it seems to be possible that the dst pointer 
> can be pointing at a valid struct that corresponds to 0.0.0.0/0.
> To ensure that we are able accurately filter out the default route, we switch 
> to the libnl function nl_addr_iszero to determine if the nl_addr struct 
> corresponds to 0.0.0.0/0.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/route.cpp bdf29a9c7090fc9483cd89e68afaa694ef271f57 
> 
> 
> Diff: https://reviews.apache.org/r/75046/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>

Reply via email to