----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75066/#review226621 -----------------------------------------------------------
support/docker-build.sh Lines 82-86 (patched) <https://reviews.apache.org/r/75066/#comment314888> should we special case 3.5 instead of 10? that way, newer versions don't use 10? can we also include ubuntu in the os check? ``` # Older versions of ubuntu don't support clang-10: if [[ "$OS" == *"ubuntu"*"16.04"* ]]; then CLANG_PKG=clang-3.5 else CLANG_PKG=clang-10 fi ``` - Benjamin Mahler On July 2, 2024, 8:09 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75066/ > ----------------------------------------------------------- > > (Updated July 2, 2024, 8:09 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > [build] fix docker-build.sh failing to compile with distcheck > > > Diffs > ----- > > support/docker-build.sh 1273848d95197891349085e74fdfedbaad6934e5 > > > Diff: https://reviews.apache.org/r/75066/diff/3/ > > > Testing > ------- > > Ran docker-build.sh with > OS="ubuntu:20.04" BUILDTOOL="autotools" COMPILER="gcc" > CONFIGURATION="--verbose --disable-parallel-test-execution > --disable-libtool-wrappers --disable-java" ENVIRONMENT='GLOG_v=1 > MESOS_VERBOSE=1' > locally, the distcheck completed but there are 44 test failures, same as what > we are currently seeing on jenkins > > > Thanks, > > Jason Zhou > >
