----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75070/#review226624 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 2, 2024, 8:34 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75070/ > ----------------------------------------------------------- > > (Updated July 2, 2024, 8:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8867 > https://issues.apache.org/jira/browse/MESOS-8867 > > > Repository: mesos > > > Description > ------- > > Our current libevent-enabled cmake builds cannot complete on jenkins as it > gets the 'incomplete definition of type 'struct bio_st'' error. > > This is because the upgrade to ubuntu 20.04 also upgraded our openSSL version > from 1.0.2 to 1.1.1, which breaks compatibility with libevent 2.1.5 that was > previously used. > A compatibility patch for openSSL 1.1+ was released with libevent 2.1.7, but > the closest tarball that includes a CMakeLists.txt file is 2.1.9, which is > what we will upgrade to. > With the new libevent library, builds are able to complete using cmake and > with libevents enabled. But it still sees the test failures we see on other > builds (such as autotools) and operating system (CentOS 7). > > We also need to link libevent_pthread and libevent_openssl with libprocess, > otherwise we will get errors like > `"ld: 3rdparty/libprocess/src/libprocess.so: undefined reference to > bufferevent_openssl_get_ssl"` > > > Diffs > ----- > > 3rdparty/CMakeLists.txt e1f71283ed75a572bc2e427685c3756ea4b15ba1 > 3rdparty/cmake/Versions.cmake acb240eef80b1a779e3e031210c9d13e2c0ea40d > 3rdparty/libprocess/src/CMakeLists.txt > d1ad7c1918f13bb562f3c649cd0d9af8d8e40ce1 > cmake/CompilationConfigure.cmake 813b255d2757ca9a79e3b34d9a88e2f4cb05bb49 > > > Diff: https://reviews.apache.org/r/75070/diff/1/ > > > Testing > ------- > > Tested on local MAC running ubuntu 20.04 amd64 image and was able to > successfully perform make without running into 'incomplete definition' > errors. Was also able to perform make check, but ran into failures as seen on > jenkins pipeline > > > Thanks, > > Jason Zhou > >
