----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75104/ -----------------------------------------------------------
(Updated July 25, 2024, 11:48 p.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- This patch adds a public helper function to abstract away the logic used to make a list comply with the 'normalized' requirements. As a reminder: An allow or deny list is 'normalized' iff everything below are true: 1. No Entry can have no accesses specified 2. No two entries on the same list can have the same type, major & minor numbers. 3. No two entries on the same list can be encompassed by the other entry. The normalize helper is available for use for all modifications to the cgroup device access state. Diffs (updated) ----- src/slave/containerizer/device_manager/device_manager.hpp 7c8523d8bdddb8e95c47e1812b48520296680ad6 src/slave/containerizer/device_manager/device_manager.cpp 4c9b86393f0809e08d79b6354940826bd56116f2 src/tests/device_manager_tests.cpp 54d464e97c8fd179128239a6757b16dfa0147c54 Diff: https://reviews.apache.org/r/75104/diff/2/ Changes: https://reviews.apache.org/r/75104/diff/1-2/ Testing ------- Updated DeviceManager tests cases to check that the state after configure fulfills the above three criteria. Tests pass Thanks, Jason Zhou
