-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75099/
-----------------------------------------------------------

(Updated July 26, 2024, 6:04 p.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

[cgroups2] Helper to check entry normalization


Repository: mesos


Description (updated)
-------

Currently we assume that a device state is normalized before using it
for generating ebpf files. However, we have not been enforcing these
constraints.

We add a helper to check if a device state is normalized so that we can
enforce these constraints.

An allow or deny list is 'normalized' iff everything below are true:
1. No Entry can have no accesses specified
2. No two entries on the same list can have the same type, major & minor
   numbers.
3. No two entries on the same list can be encompassed by the other
   entry.


Diffs (updated)
-----

  src/linux/cgroups2.hpp accaebdaddc85acdd96b87161ea441c77b025099 
  src/linux/cgroups2.cpp ac46782614f6b3b6cb6f2f685492df8364cb73a3 
  src/tests/containerizer/cgroups2_tests.cpp 
39f17460c8911244ba28ab052281785dd6235240 


Diff: https://reviews.apache.org/r/75099/diff/7/

Changes: https://reviews.apache.org/r/75099/diff/6-7/


Testing (updated)
-------

Added tests for normalized(). Tests passed.


Thanks,

Jason Zhou

Reply via email to