----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75114/#review226726 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 26, 2024, 6:04 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75114/ > ----------------------------------------------------------- > > (Updated July 26, 2024, 6:04 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > We currently do not enforce normalized allow and deny in configure. > However, to ensure that we can generate an ebpf program that behaves > correctly, we have to ensure that allow and deny are normalized. > > This patch adds a validation check to ensure that the allow and deny are > normalized before attempting to generate the ebopf program. > > > Diffs > ----- > > src/linux/cgroups2.cpp ac46782614f6b3b6cb6f2f685492df8364cb73a3 > src/tests/containerizer/cgroups2_tests.cpp > 39f17460c8911244ba28ab052281785dd6235240 > > > Diff: https://reviews.apache.org/r/75114/diff/1/ > > > Testing > ------- > > Tests added for the validation in configure(), tests pass. > > > Thanks, > > Jason Zhou > >
