----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75115/#review226727 -----------------------------------------------------------
Ship it! - Benjamin Mahler On July 26, 2024, 6:04 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75115/ > ----------------------------------------------------------- > > (Updated July 26, 2024, 6:04 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently in the configure() and reconfigure() functions in device > manager, we do not ensure that the device access state at the end of the > function call is normalized. So we incorporate normalized() and > normalize() calls to ensure that the allow and deny lists are always > normalized at the end of a configure() or reconfigure() call. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.cpp > 4c9b86393f0809e08d79b6354940826bd56116f2 > src/tests/device_manager_tests.cpp 54d464e97c8fd179128239a6757b16dfa0147c54 > > > Diff: https://reviews.apache.org/r/75115/diff/1/ > > > Testing > ------- > > Modified current tests to ensure that the final expected states are > normalized. tests pass. > > > Thanks, > > Jason Zhou > >
