----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75116/#review226728 -----------------------------------------------------------
Ship it! can simplify checks with .second on the emplace result - Benjamin Mahler On July 26, 2024, 10:04 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75116/ > ----------------------------------------------------------- > > (Updated July 26, 2024, 10:04 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, CgroupDeviceAccess instances can be directly constructed > without verifying that its allow and deny lists are normalized. > > To codify our normalization constraints, CgroupDeviceAccess can now only > be created with a create() helper. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.hpp > c0ffcc20fa8facdd25b45f3c3f8bf4a8a26e1fdb > src/slave/containerizer/device_manager/device_manager.cpp > c25af0adc142f4254db67f17d7f768cedb164af9 > src/tests/device_manager_tests.cpp da1ef64fe36d3050284210e5442cfc96db9adae5 > > > Diff: https://reviews.apache.org/r/75116/diff/2/ > > > Testing > ------- > > Refactored existing tests to use create(), tests pass. > > > Thanks, > > Jason Zhou > >
