----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75016/#review226736 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Line 371 (original), 371-372 (patched) <https://reviews.apache.org/r/75016/#comment315008> We create a deviceManager here so that it can be passed to both the GPU isolator and cgroups2 isolator. Since it's a shared pointer, I think it should be fine as long as the GPU isolator/device dontroller makes a member variable via the copy ctor and increases the ref count. src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Lines 86-89 (patched) <https://reviews.apache.org/r/75016/#comment315007> the creatorsWithDeviceManager will include deviceManager. I made it separate from the other controllers because the others dont seem to need DeviceManager, and I want to pass the DeviceManager in on a need-to basis - Jason Zhou On July 29, 2024, 3:24 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75016/ > ----------------------------------------------------------- > > (Updated July 29, 2024, 3:24 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Passes the device manager to the cgroups2 isolator on containerizer > startup, and sets up the ability for the manager to be passed to the > device controller and GPU isolator > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp > 691fdfe295850bce1302b4adde127d551f821b89 > src/slave/containerizer/mesos/containerizer.cpp > f7ff6b8e56e80881ac89ba650b7aa4f4eec3484b > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.hpp > d60215ec1c722efced2d5c59b9f99cb67d1abbbe > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 2ca3880790be0cd092ec05a359711e2d8e641314 > > > Diff: https://reviews.apache.org/r/75016/diff/7/ > > > Testing > ------- > > Compiles successfully > > > Thanks, > > Jason Zhou > >
