----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75098/#review226751 -----------------------------------------------------------
Fix it, then Ship it! Will make local edits to fix the blocking. src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp Lines 185 (patched) <https://reviews.apache.org/r/75098/#comment315014> never block within Processes src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp Lines 212 (patched) <https://reviews.apache.org/r/75098/#comment315013> never block within Processes - Benjamin Mahler On July 29, 2024, 9:05 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75098/ > ----------------------------------------------------------- > > (Updated July 29, 2024, 9:05 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces a device controller that supports cgroups v2 and is available > in the Cgroups2IsolatorProcess. Device access control is made through > the DeviceManager. > > > Diffs > ----- > > src/CMakeLists.txt 9526ed17a1ccb88941fdfa3cea923c9260f68c43 > src/Makefile.am 456942389b4770ab1109ab5cdf370b004b1b9462 > src/slave/containerizer/mesos/isolators/cgroups2/constants.hpp > bad79ad0c2d02c84e361a24b5376298f76341692 > src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp > PRE-CREATION > > > Diff: https://reviews.apache.org/r/75098/diff/4/ > > > Testing > ------- > > Compiles ok, testing needs to be done through the GPU isolator tests > > > Thanks, > > Jason Zhou > >
