----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75162/ -----------------------------------------------------------
(Updated Aug. 12, 2024, 6:16 p.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description (updated) ------- Currently, we cannot use the cgroups/all flag to its corresponding controllers in cgroups2. The flag causes us to grabs all the values in the cgroup.controllers file. But we should instead just add all the creators when we see cgroups/all, as many controllers are no longer present in cgroup.controllers in cgroups v2. This fix incidentally fixes the ROOT_CGROUPS_AgentRecoveryWithNewCgroupSubsystems test as it was unable to create the memory controller using cgroups/all flag. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 4174be0fab3ef28740686eaf20bee5fb7ae4282a Diff: https://reviews.apache.org/r/75162/diff/3/ Changes: https://reviews.apache.org/r/75162/diff/2-3/ Testing ------- ROOT_CGROUPS_AgentRecoveryWithNewCgroupSubsystems passes. Thanks, Jason Zhou
