----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75184/#review226875 -----------------------------------------------------------
Ship it! Looks good now, let's just also add a test of discarding the future. - Benjamin Mahler On Aug. 22, 2024, 7:33 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75184/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2024, 7:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > We add an OomListener process to allow users to listen for oom events > in a cgroup or any of its descendants. > > If the OomListener is terminated, any remaining unsatisfied futures will > be failed. > > If the listened cgroup or any of its descendants encounters an oom > event, then the returned future from listen() will become ready, and > action can be taken upon the oom event via future onReady handlers. > > > Diffs > ----- > > src/linux/cgroups2.hpp e13e57076ab7a7b9977a2eec9eeaa3c8635a98e1 > src/linux/cgroups2.cpp d1c415db8b086ac0c4c70cd9616f7e8777d34afc > src/tests/containerizer/cgroups2_tests.cpp > fc38995263eff6d9d14ba422471457a1affdbde8 > > > Diff: https://reviews.apache.org/r/75184/diff/3/ > > > Testing > ------- > > Added tests for OomListener for behaviors: future becomes ready when oom > occurs, future is discarded if OomListener terminates > > > Thanks, > > Jason Zhou > >
