----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75189/#review226881 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 23, 2024, 3:29 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75189/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2024, 3:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The Todos mention recovery support for the device manager, and to use > the device manager recover in the device controller process. > > We have added checkpointing and recovery support in: > https://reviews.apache.org/r/75145 > > We also only use the device manager recovery in the cgroups2 isolator > instead of in the device controller, as implemented in: > https://reviews.apache.org/r/75149/ > > As such, these todos are considered completed, and can be removed. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.hpp > 0a8ea4f93b4fcf2f20d8cbf4bd8d1acf31ec4339 > src/slave/containerizer/mesos/isolators/cgroups2/controllers/devices.cpp > 702ed50b0588c2c000442b97c3daf0668a66bce9 > > > Diff: https://reviews.apache.org/r/75189/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
