Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10826804
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,11 @@ private[ui] class StageTable(stages: Seq[StageInfo],
parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed:
String, total: Int): Seq[Node] =
{
- val completeWidth = "width:
%s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val completeWidth = "width: %s%%; position:
absolute;".format((completed.toDouble/total)*100)
+ val startWidth = "width: %s%%; left: %s%%; position:
absolute;".format((started.toDouble/total)*100)
--- End diff --
This line is too long for the style guide. Also - will this throw a string
format exception? (there are two cases of %s but only one argument passed to
`format`.
```
val startPct = (started.toDouble/total)*100
val startWidth = "width: %s%%; left: %s%%; position:
absolute;".format(startPct, startPct)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
