Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/205#issuecomment-38353915
Hey Cheng, this looks really good. My only comment is we should probably
restrict the visibility of all these new object so they don't show up in the
scala doc. I think everything should be private[sql].
Otherwise, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
