Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/208#issuecomment-38415798
  
    ```scala
    package org.apache.spark.sql
    package catalyst
    ```
    vs
    ```scala
    package org.apache.spark.sql.catalyst
    ```
    
    There are three reasons I think it'd be better to just have one package 
statement in a file. 
    
    1. It is easier to understand by most programmers, especially the ones that 
come from Java land (I was chatting with another committer just now and he got 
confused by the meaning of having two or three package statements in a Scala 
file).
    
    2. It requires explicit import to open up the parent package scope and 
avoids polluting the namespace (there is no difference in terms of line count 
here since you add one import but remove one package)
    
    3. It is more consistent with the rest of Spark code base.
    
    Now this is a highly subjective topic, so we should get others to chime in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to