Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/250#discussion_r11012078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
@@ -15,23 +15,33 @@
* limitations under the License.
*/
-package org.apache.spark.sql.execution
+package org.apache.spark.sql
+package execution
-import scala.collection.mutable
+import scala.collection.mutable.{ArrayBuffer, BitSet}
import org.apache.spark.rdd.RDD
import org.apache.spark.SparkContext
-import org.apache.spark.sql.catalyst.errors._
-import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.catalyst.plans._
-import
org.apache.spark.sql.catalyst.plans.physical.{ClusteredDistribution,
Partitioning}
+import catalyst.errors._
+import catalyst.expressions._
+import catalyst.plans._
+import catalyst.plans.physical.{ClusteredDistribution, Partitioning}
-import org.apache.spark.rdd.PartitionLocalRDDFunctions._
+sealed abstract class BuildSide
+case object BuildLeft extends BuildSide
+case object BuildRight extends BuildSide
-case class SparkEquiInnerJoin(
+object InterpretCondition {
+ def apply(expression: Expression): (Row => Boolean) = {
--- End diff --
Do you think we will use this multiple times? If not.. maybe just put it
inline where it is used? The signature of this whole function is not super easy
to read
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
