Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/245#discussion_r11013983 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala --- @@ -67,44 +70,50 @@ class RidgeRegressionWithSGD private ( .setMiniBatchFraction(miniBatchFraction) // We don't want to penalize the intercept in RidgeRegression, so set this to false. - setIntercept(false) + super.setIntercept(false) var yMean = 0.0 - var xColMean: DoubleMatrix = _ - var xColSd: DoubleMatrix = _ + var xColMean: BV[Double] = _ + var xColSd: BV[Double] = _ --- End diff -- add `private` modifier like in `LassoRegression`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---