Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/247#issuecomment-39402799
Hey TD - Did a pass. Had some questions and surface level comment.
One thing that came up a few was the use of a busy-wait/Thread.sleep along
with interruption. Ideally rather than calling sleep in a loop you would sleep
on a condition variable and notify it in the other thread. With the current
approach you anyways have to keep a pointer to the thread so it knows what to
interrupt. Why not just have a CV?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
