Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/126#discussion_r11265456
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/HttpBroadcast.scala ---
@@ -183,20 +197,48 @@ private object HttpBroadcast extends Logging {
obj
}
- def cleanup(cleanupTime: Long) {
+ /**
+ * Remove all persisted blocks associated with this HTTP broadcast on
the executors.
+ * If removeFromDriver is true, also remove these persisted blocks on
the driver
+ * and delete the associated broadcast file.
+ */
+ def unpersist(id: Long, removeFromDriver: Boolean) = synchronized {
--- End diff --
shouldn't this one be private? I feel like exposing the `removeFromDriver =
true` code path to users is dangerous. Or at least, I'm not sure why we'd
expose it here and not just make `destroy()` public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
