Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/217#discussion_r11378521
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -95,4 +109,22 @@ object TestUtils {
result.renameTo(out)
out
}
+
+ /** Creates a compiled class with the given name. Class file will be
placed in destDir. */
--- End diff --
This is very redundant with `createCompiledClass`. Why not just make the
`value` optional and we can have a default (there is no harm in having an extra
field even if some tests might not use it). Also maybe the value should be a
`String` here since it gets stringified anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
