Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/217#discussion_r11416979
  
    --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
    @@ -34,13 +34,14 @@ object TestUtils {
        * Note: if this is used during class loader tests, class names should 
be unique
        * in order to avoid interference between tests.
        */
    -  def createJarWithClasses(classNames: Seq[String]): URL = {
    +  def createJarWithClasses(classNames: Seq[String], value: String = ""): 
URL = {
    --- End diff --
    
    This class will need to be made package private if it goes into `main` 
instead of `test`. I can do this when merging, just putting a reminder here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to