Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/383#discussion_r11563442
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -38,12 +38,19 @@ def launch_gateway():
             # Don't send ctrl-c / SIGINT to the Java gateway:
             def preexec_func():
                 signal.signal(signal.SIGINT, signal.SIG_IGN)
    -        proc = Popen(command, stdout=PIPE, stdin=PIPE, 
preexec_fn=preexec_func)
    +        proc = Popen(command, stdout=PIPE, stdin=PIPE, stderr=PIPE, 
preexec_fn=preexec_func)
         else:
             # preexec_fn not supported on Windows
    -        proc = Popen(command, stdout=PIPE, stdin=PIPE)
    -    # Determine which ephemeral port the server started on:
    -    port = int(proc.stdout.readline())
    +        proc = Popen(command, stdout=PIPE, stdin=PIPE, stderr=PIPE)
    +
    +    try: 
    +      # Determine which ephemeral port the server started on:
    +      port = int(proc.stdout.readline())
    +    except:
    +      error_code = proc.poll()
    +      raise Exception("Launching SparkContext failed with exit code %d: 
%s" %
    --- End diff --
    
    Maybe this should say "Launching GatewayServer failed"? It will be more 
informative, otherwise people will think something is wrong with SparkContext 
itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to