Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/299#discussion_r11567194
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -340,8 +341,22 @@ trait ClientBase extends Logging {
           JAVA_OPTS += " -XX:CMSIncrementalDutyCycle=10 "
         }
     
    -    if (env.isDefinedAt("SPARK_JAVA_OPTS")) {
    -      JAVA_OPTS += " " + env("SPARK_JAVA_OPTS")
    +
    --- End diff --
    
    Thinking a bit more, we have two options here:
    
    (a) make a backwards incompatible change here and people have to re-write 
there jobs
    (b) continue supporting shipping SPARK_JAVA_OPTS from the driver to the 
executors for the entire 1.X family of Spark releases (e.g probably years).
    
    I guess we can do (a) but I might give a loud error message here so that 
users change this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to