Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/397#issuecomment-40320487
Yes I knew about biased locking. That's why I said "how well the jvm can do
away with the lock that is always running in a single threaded mode". However,
it is hard to test how well it works with all the random cases (large streams,
small streams, and even with biased locking it is not free) we have for this
and quantify the impact. And given how small and simple this code is, I think
it is fine as is.
I removed the trim method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
