Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/339#issuecomment-40321243
Hi, @kayousterhout, you mean just split the test cases and move some of
them to another file?
I can do that...but do you think the test cases specific to the
TaskSchedulerImpl class are also missed?
I think the implementation in this patch is equivalent to the original one,
as we assume the locality is Any and the assert statements are actually testing
the results of rootPool.getSortedTaskSetQueue(),
I think for fully test the critical code path of TaskSchedulerImpl, we need
some test cases on the locality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
