HyukjinKwon commented on a change in pull request #27039: [SPARK-29174][SQL]
LOCAL is not supported in INSERT OVERWRITE DIRECTORY to data source
URL: https://github.com/apache/spark/pull/27039#discussion_r361910584
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -793,11 +793,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
*/
override def visitInsertOverwriteDir(
ctx: InsertOverwriteDirContext): InsertDirParams = withOrigin(ctx) {
- if (ctx.LOCAL != null) {
Review comment:
Seems `ctx.LOCAL != null` should be returned instead of `false`. Also, it
seems "insert overwrite into local" with data sources of spark isn't
implemented yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
