Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4525#discussion_r24635360
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -66,6 +68,11 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
@volatile private var applications: mutable.LinkedHashMap[String,
FsApplicationHistoryInfo]
= new mutable.LinkedHashMap()
+ // The logCheckingThread appends elements at the end of
lazyApplications, while
+ // the logLazyReplayThread removes elements from the begin of
lazyApplications.
+ private val lazyApplications = new mutable.LinkedHashMap[String,
LazyFsApplicationHistoryInfo]()
+ with mutable.SynchronizedMap[String, LazyFsApplicationHistoryInfo]
--- End diff --
though here since we need to maintain the order, we might have to use
`ConcurrentSkipListMap` instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
