cloud-fan commented on a change in pull request #26850: [SPARK-30215][SQL]
Remove PrunedInMemoryFileIndex and merge its functionality into
InMemoryFileIndex
URL: https://github.com/apache/spark/pull/26850#discussion_r362383631
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala
##########
@@ -81,8 +81,9 @@ class CatalogFileIndex(
}
val partitionSpec = PartitionSpec(partitionSchema, partitions)
val timeNs = System.nanoTime() - startTime
- new PrunedInMemoryFileIndex(
- sparkSession, new Path(baseLocation.get), fileStatusCache,
partitionSpec, Option(timeNs))
+ new InMemoryFileIndex(sparkSession,
partitionSpec.partitions.map(_.path), Map.empty,
Review comment:
nit: can we use named parameter?
```
new InMemoryFileIndex(
sparkSession,
rootPathsSpecified = partitionSpec.partitions.map(_.path),
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
