yaooqinn commented on a change in pull request #26995: [SPARK-30341][SQL]
Overflow check for interval arithmetic operations
URL: https://github.com/apache/spark/pull/26995#discussion_r362399560
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -110,49 +110,51 @@ object ExtractIntervalPart {
}
}
-abstract class IntervalNumOperation(
- interval: Expression,
- num: Expression,
- operation: (CalendarInterval, Double) => CalendarInterval,
- operationName: String)
+abstract class IntervalNumOperation(interval: Expression, num: Expression,
operationName: String)
extends BinaryExpression with ImplicitCastInputTypes with Serializable {
+
override def left: Expression = interval
override def right: Expression = num
override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType,
DoubleType)
+
override def dataType: DataType = CalendarIntervalType
override def nullable: Boolean = true
- override def nullSafeEval(interval: Any, num: Any): Any = {
- try {
- operation(interval.asInstanceOf[CalendarInterval],
num.asInstanceOf[Double])
- } catch {
- case _: java.lang.ArithmeticException => null
- }
+ override def nullSafeEval(interval: Any, num: Any): Any = operationName
match {
+ case "multiply" =>
+ multiplyExact(interval.asInstanceOf[CalendarInterval],
num.asInstanceOf[Double])
+ case "divide" =>
+ if (num == 0) return null
Review comment:
shall we fix numerics / 0 when ANSI is on too in a followup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
