maropu commented on a change in pull request #26997: [SPARK-30343][SQL] Skip
unnecessary checks in RewriteDistinctAggregates
URL: https://github.com/apache/spark/pull/26997#discussion_r362436520
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -101,8 +101,17 @@ import org.apache.spark.sql.types.IntegerType
*/
object RewriteDistinctAggregates extends Rule[LogicalPlan] {
+ private def mayNeedtoRewrite(exprs: Seq[Expression]): Boolean = {
+ val distinctAggs = exprs.flatMap { _.collect {
+ case ae: AggregateExpression if ae.isDistinct => ae
+ }}
+ // We need at least two distinct aggregates for this rule because
aggregation
+ // strategy can handle a single distinct group.
+ distinctAggs.size > 1
+ }
+
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
- case a: Aggregate => rewrite(a)
+ case a: Aggregate if mayNeedtoRewrite(a.aggregateExpressions) => rewrite(a)
Review comment:
yea, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
