cloud-fan commented on a change in pull request #27095: [SPARK-30214][SQL] V2
commands resolves namespaces with new resolution framework
URL: https://github.com/apache/spark/pull/27095#discussion_r363181136
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -191,22 +191,19 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
s"because view support in catalog has not been implemented yet")
case c @ CreateNamespaceStatement(NonSessionCatalogAndNamespace(catalog,
ns), _, _) =>
- CreateNamespace(catalog.asNamespaceCatalog, ns, c.ifNotExists,
c.properties)
+ CreateNamespace(catalog, ns, c.ifNotExists, c.properties)
case DropNamespaceStatement(NonSessionCatalogAndNamespace(catalog, ns),
ifExists, cascade) =>
DropNamespace(catalog, ns, ifExists, cascade)
case DescribeNamespaceStatement(NonSessionCatalogAndNamespace(catalog,
ns), extended) =>
- DescribeNamespace(catalog.asNamespaceCatalog, ns, extended)
+ DescribeNamespace(catalog, ns, extended)
Review comment:
yea, we should have an extra analyzer rule to catch
```
case DescribeNamespace(ResolvedNamespace(catalog, ident)) if
isSessionCatalog(catalog)
```
and convert to v1 command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
