HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571432884 The thing is that it "conditionally" works which is very confusing because the condition is whether the query statement goes into visitCreateHiveTable or not. (And it's also confused visitCreateHiveTable has Hive as default provider, whereas we are saying we use `spark.sql.sources.default` as default provider) `STORED AS` was the key to go into visitCreateHiveTable (that's the reason SPARK-30098 adds it here and there) but do we expect end users to realize the difference between two? And since we rely on parser rule and simply fail on visitCreateTable with external, `CREATE EXTERNAL TABLE USING HIVE ... LOCATION` doesn't work. And `CREATE EXTERNAL TABLE ... LOCATION` with hive as default source will also fail because of same reason.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org