HeartSaVioR commented on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571474000 > It's common to define the possible mistakes in the syntax rule ... I see. That totally makes sense. Thanks for the details. Btw, while we don't seem to have doc for create table, I somehow found the doc for create table, https://docs.databricks.com/spark/latest/spark-sql/language-manual/create-table.html (I'm expecting some difference but doesn't look to be major.) Unlike current Spark master branch, the two syntaxes of create table in the doc are clear to differentiate, because the first syntax "forces" to specify "USING datasource", making both syntaxes be mutually exclusive. If end users specify USING datasource, it will leverage the first syntax. Otherwise it will leverage the second syntax. In current Spark master branch, both syntaxes are not mutually exclusive and hence relying on the order of parser rule file. If we change the order of createTable and createHiveTable then something will be broken. Moreover we may not want to explain end users this behavior since it's not easy to understand and also easy to make mistake. Hope this helps make my goal be clear.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
